remove redundant calls to set spinning false

wjwwood · wjwwood · commit f1e7ea5ca08e · 2015-11-16T17:30:01.000-08:00
diff --git a/rclcpp/src/rclcpp/executor.cpp b/rclcpp/src/rclcpp/executor.cpp
@@ -118,7 +118,6 @@ Executor::spin_some()
   while ((any_exec = get_next_executable(std::chrono::milliseconds::zero())) && spinning.load()) {
     execute_any_executable(any_exec);
   }
-  spinning.store(false);
 }
 
 void
@@ -132,7 +131,6 @@ Executor::spin_once(std::chrono::nanoseconds timeout)
   if (any_exec) {
     execute_any_executable(any_exec);
   }
-  spinning.store(false);
 }
 
 void
diff --git a/rclcpp/src/rclcpp/executors/multi_threaded_executor.cpp b/rclcpp/src/rclcpp/executors/multi_threaded_executor.cpp
@@ -55,7 +55,6 @@ MultiThreadedExecutor::spin()
   for (auto & thread : threads) {
     thread.join();
   }
-  spinning.store(false);
 }
 
 size_t
diff --git a/rclcpp/src/rclcpp/executors/single_threaded_executor.cpp b/rclcpp/src/rclcpp/executors/single_threaded_executor.cpp
@@ -36,5 +36,4 @@ SingleThreadedExecutor::spin()
     auto any_exec = get_next_executable();
     execute_any_executable(any_exec);
   }
-  spinning.store(false);
 }

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ Executor::spin_some()`
`118`	`118`	`while ((any_exec = get_next_executable(std::chrono::milliseconds::zero())) && spinning.load()) {`
`119`	`119`	`execute_any_executable(any_exec);`
`120`	`120`	`}`
`121`		`- spinning.store(false);`
`122`	`121`	`}`
`123`	`122`
`124`	`123`	`void`
`@@ -132,7 +131,6 @@ Executor::spin_once(std::chrono::nanoseconds timeout)`
`132`	`131`	`if (any_exec) {`
`133`	`132`	`execute_any_executable(any_exec);`
`134`	`133`	`}`
`135`		`- spinning.store(false);`
`136`	`134`	`}`
`137`	`135`
`138`	`136`	`void`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ MultiThreadedExecutor::spin()`
`55`	`55`	`for (auto & thread : threads) {`
`56`	`56`	`thread.join();`
`57`	`57`	`}`
`58`		`- spinning.store(false);`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`size_t`
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,4 @@ SingleThreadedExecutor::spin()`
`36`	`36`	`auto any_exec = get_next_executable();`
`37`	`37`	`execute_any_executable(any_exec);`
`38`	`38`	`}`
`39`		`- spinning.store(false);`
`40`	`39`	`}`