node interfaces: fix unintentionally invoked copy constructor by explicitly getting a reference using a lambda instead of a conditional operator where the type is NodeT instead of NodeT &

fabianhirmann · fabianhirmann · commit b41fe0c385d4 · 2025-12-09T11:14:42.000+01:00
Signed-off-by: Fabian Hirmann &lt;f.hirmann@arti-robots.com&gt;
diff --git a/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp b/rclcpp/include/rclcpp/node_interfaces/node_interfaces.hpp
@@ -150,7 +150,13 @@ class NodeInterfaces
   /// NodeT::SharedPtr Constructor
   template<typename NodeT>
   NodeInterfaces(std::shared_ptr<NodeT> node)  // NOLINT(runtime/explicit)
-  : NodeInterfaces(node ? *node : throw std::invalid_argument("given node pointer is nullptr"))
+  : NodeInterfaces(
+      [&]() -> NodeT & {
+        if (!node) {
+          throw std::invalid_argument("given node pointer is nullptr");
+        }
+        return *node;
+      }())
   {}
 
   explicit NodeInterfaces(std::shared_ptr<InterfaceTs>... args)
