Added include dir to installation of rcl_logging_log4cxx.#7
Merged
clalancette merged 1 commit intoros2:masterfrom May 1, 2019
Merged
Added include dir to installation of rcl_logging_log4cxx.#7clalancette merged 1 commit intoros2:masterfrom
clalancette merged 1 commit intoros2:masterfrom
Conversation
nburek
approved these changes
Apr 30, 2019
Contributor
|
@thomas-moulard - please run the following CI job:
|
thomas-moulard
approved these changes
Apr 30, 2019
|
This looks like an unrelated flake8 regressions in the idl generator on all platforms. Possibly related to ros2/rosidl#371 @jacobperron |
Contributor
|
Looks like the regression may have been fixed here too: ros2/rosidl#373 |
clalancette
approved these changes
May 1, 2019
Contributor
clalancette
left a comment
There was a problem hiding this comment.
The change looks good to me with green CI.
dirk-thomas
approved these changes
May 1, 2019
|
The CI failed some tests. This is now hitting a There's a recent change related here: ros2/rcl#405 |
Contributor
|
Oh, I see what happened. We merged ros2/rcl#405, which means that ros2/rcl#425 needs a rebase now. As @dirk-thomas suggested, this is only installing stuff that wasn't there before, so I'm going to merge this anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #5. This enables compiling ROS2 with log4cxx (by setting RCL_LOGGING_IMPLEMENTATION to rcl_logging_log4cxx).