Skip to content

Remove unused ParameterEventDescriptors.msg#90

Closed
brawner wants to merge 1 commit intoros2:masterfrom
brawner:remove_parametereventdescriptors
Closed

Remove unused ParameterEventDescriptors.msg#90
brawner wants to merge 1 commit intoros2:masterfrom
brawner:remove_parametereventdescriptors

Conversation

@brawner
Copy link
Copy Markdown
Contributor

@brawner brawner commented Mar 20, 2020

This message file was added several years ago and is not currently in use. Instead of adding documentation for an unused feature, I figured it would be better to just remove the message for now.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Copy Markdown
Contributor Author

brawner commented Mar 20, 2020

@tfoote This was message I was talking about. We can also leave it in if that's preferable.

Copy link
Copy Markdown
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message was part of the design to provide a way for UIs to subscribe to a lighter weight version of the ParameterEvents topic. In particular they would be expected to subscribe to this and then only call getParameter for the ones that they care about.

For most parameters this isn't a big deal, but for large parameters with lots of data this will significantly reduce the volume. As well as for tools that may want to support reconfiguring anything, but might only have a few parameters actively in the configuration gui this lets them be responsive, but not hog bandwidth. We ran out of time to implement that and didn't have the demand for it yet. but I think we should instead plan to implement that rather than removing this message.

@brawner
Copy link
Copy Markdown
Contributor Author

brawner commented Apr 3, 2020

Ok, good points. I'll add information about it to the documentation PR, and maybe a one-liner that the feature has not yet been implemented. I have no issue with it sticking around if you still think it will be part of future functionality.

@brawner brawner closed this Apr 3, 2020
@brawner brawner deleted the remove_parametereventdescriptors branch April 3, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants