Merged
Conversation
18c3ad7 to
9811461
Compare
hidmic
reviewed
Feb 23, 2019
hidmic
left a comment
There was a problem hiding this comment.
LGTM, though many of the test values have changed e.g. 0x7F != 255, 0x11 != 11, etc. But I can't seem to find anything relying on them so I think we're fine.
Member
Author
Just because the type and valid value range has changed. |
hidmic
approved these changes
Feb 25, 2019
|
Looks like I don't have true powers here :( |
9811461 to
0469d0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rosidl#334.