Merged
Conversation
dirk-thomas
approved these changes
Oct 30, 2018
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
Would it make sense to renumber the constants?
Contributor
Author
|
@dirk-thomas Any recommendations for it? Do have specific numbering in mind? |
dirk-thomas
reviewed
Oct 31, 2018
lifecycle_msgs/msg/Transition.msg
Outdated
| uint8 TRANSITION_SHUTDOWN = 5 | ||
| uint8 TRANSITION_UNCONFIGURED_SHUTDOWN = 50 | ||
| uint8 TRANSITION_INACTIVE_SHUTDOWN = 51 | ||
| uint8 TRANSITION_ACTIVE_SHUTDOWN = 52 |
Member
There was a problem hiding this comment.
Maybe 5 - 7 for the new transitions and bumping TRANSITION_DESTROY to 8?
|
|
||
| uint8 TRANSITION_UNCONFIGURED_SHUTDOWN = 50 | ||
| uint8 TRANSITION_INACTIVE_SHUTDOWN = 51 | ||
| uint8 TRANSITION_ACTIVE_SHUTDOWN = 52 |
Member
There was a problem hiding this comment.
Maybe 50 - 52 for the remaining on-shutdown transitions?
Contributor
Author
|
@dirk-thomas does that look correct to you? |
dirk-thomas
approved these changes
Nov 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes ros2/rcl#309