Skip to content

[Backport Foxy] Update QD#843

Merged
ahcorde merged 8 commits intofoxyfrom
ahcorde/foxy/qd
Nov 5, 2020
Merged

[Backport Foxy] Update QD#843
ahcorde merged 8 commits intofoxyfrom
ahcorde/foxy/qd

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Oct 27, 2020

No description provided.

christophebedard and others added 4 commits October 27, 2020 15:19
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Update quality level and coverage

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed wording and links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated QD

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from brawner October 27, 2020 14:21
@ahcorde ahcorde self-assigned this Oct 27, 2020
christophebedard and others added 2 commits October 29, 2020 09:03
List tracetools in rcl_lifecycle's QD

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Copy Markdown

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several levels need fixing

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina November 3, 2020 08:02
Copy link
Copy Markdown

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more links

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina November 4, 2020 07:11
Copy link
Copy Markdown

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahcorde ahcorde merged commit 4376552 into foxy Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/foxy/qd branch November 5, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants