[Foxy backport] Topic fix rcl lifecycle test issue (#715)#796
Merged
Conversation
* Fix missing call fini() for lifecycle_transition and node in test_rcl_lifecycle Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix error overwritten while allocator is Nullptr. Signed-off-by: Barry Xu <barry.xu@sony.com> * Optimize used variables Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
Merging with just PR job since it's a cherry-pick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports to fix flaky test in Foxy CI debug CI jobs: http://build.ros2.org/job/Fci__nightly-debug_ubuntu_focal_amd64/181/testReport/junit/(root)/projectroot/test_rcl_lifecycle/
Without this backport, I'm able to reproduce the test crashing consistently with a few dozen attempts. With this backport I was not able to reproduce the test failure with
--retest-until-fail 1000Backports #715