[foxy backport] Keep domain id if ROS_DOMAIN_ID is invalid. (#689)#694
Merged
[foxy backport] Keep domain id if ROS_DOMAIN_ID is invalid. (#689)#694
Conversation
Contributor
Author
|
About a fraction of #668 coming in with this PR. That commit bundles a lot of tests. We can backport them all before this PR instead of bringing in only a fraction of it as it is done here. I don't have a strong opinion. |
fujitatomoya
approved these changes
Jun 23, 2020
jacobperron
approved these changes
Jun 23, 2020
Member
jacobperron
left a comment
There was a problem hiding this comment.
LGTM
I also don't feel strongly about backporting the remaining tests from #668
a5af9a2 to
7a29617
Compare
Including domain id tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
7a29617 to
a5f9aad
Compare
jacobperron
approved these changes
Jun 26, 2020
Member
|
This change broke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including domain id tests (some coming from #668).