Skip to content

Address unused parameter warnings#666

Merged
brawner merged 1 commit intomasterfrom
brawner/fix-unused-warning
May 29, 2020
Merged

Address unused parameter warnings#666
brawner merged 1 commit intomasterfrom
brawner/fix-unused-warning

Conversation

@brawner
Copy link
Copy Markdown
Contributor

@brawner brawner commented May 29, 2020

Removing the if statements in #663 caused unused parameter warnings in release mode. This adds in no-ops to remove the warnings.

Example failure:

  • Linux Build Status

Fixed issue, built in release mode

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Debug mode:

  • Linux Build Status

Signed-off-by: Stephen Brawner <brawner@gmail.com>
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@brawner brawner merged commit 9ad198e into master May 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/fix-unused-warning branch May 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants