transition start and goal states can be null#662
Merged
Karsten1987 merged 2 commits intomasterfrom May 27, 2020
Merged
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Contributor
Author
|
CI: (building up to rclcpp_lifeycycle, testing rcl_lifecycle & rclcpp_lifecycle):
|
hidmic
approved these changes
May 27, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Contributor
Author
|
didn't push the adaptions of the tests correctly. once more:
|
Member
|
|
Contributor
Author
|
I believe these are related to ros2/rclcpp#1134 (comment) I don't think they are related to the changes in |
Member
Lovely ❤️ |
ivanpauno
approved these changes
May 27, 2020
brawner
approved these changes
May 27, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Thanks for taking care of this Karsten!
Member
Proposed fix in ros2/rclcpp#1136. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle transitions can be lazy initialized, meaning that the start and goal state can be null at the time of initialization: https://github.com/ros2/rclcpp/blob/87bb9f9758dce239d37256ae91d58ce6325f405b/rclcpp_lifecycle/src/transition.cpp#L155-L156
This should fix the regression stated in here; #649 (comment)