[dashing backport] MAX_STRING_SIZE increase#503
Merged
dirk-thomas merged 1 commit intoros2:dashingfrom Sep 19, 2019
zmichaels11:zmichaels11/backport-#487
Merged
[dashing backport] MAX_STRING_SIZE increase#503dirk-thomas merged 1 commit intoros2:dashingfrom zmichaels11:zmichaels11/backport-#487
dirk-thomas merged 1 commit intoros2:dashingfrom
zmichaels11:zmichaels11/backport-#487
Conversation
* Increase MAX_STRING_SIZE It's too short for string length. It occurs the error when the string field in yaml files are too long.... Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com> * update test to match increased limit Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Author
|
Member
|
The patch looks fine to me but the CI builds seem to test master not dashing? |
Contributor
|
@zmichaels11 please relaunch CI using a repos file that's branched from the dashing branch. https://github.com/ros2/ros2/blob/dashing/ros2.repos |
Author
|
Trying again, but with dashing
|
Author
|
@dirk-thomas its passing now |
Member
|
@ros-pull-request-builder retest this please |
Member
|
Thanks for making the backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashing backport of #487