Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
left a comment
There was a problem hiding this comment.
I left some minor comments. Besides that, LGTM.
| rcl_params_t * params_st); | ||
|
|
||
| /// \brief Print the parameter structure to stdout | ||
| /// \brief Print the parameter structure to |
rcl_yaml_param_parser/src/parser.c
Outdated
| break; | ||
| default: | ||
| res = RCL_RET_ERROR; | ||
| ret = RCUTILS_RET_OK; |
There was a problem hiding this comment.
RCL_RET_ERROR -> RCUTILS_RET_OK ?
rcl_yaml_param_parser/src/parser.c
Outdated
| if (NULL == value) { | ||
| RCUTILS_SET_ERROR_MSG("event argument has no value"); | ||
| return RCUTILS_RET_INVALID_ARGUMENT; | ||
| } |
rcl_yaml_param_parser/src/parser.c
Outdated
| if (NULL == value) { | ||
| RCUTILS_SET_ERROR_MSG("event argument has no value"); | ||
| return RCUTILS_RET_INVALID_ARGUMENT; | ||
| } |
There was a problem hiding this comment.
Use RCUTILS_CHECK_FOR_NULL_WITH_MSG
rcl_yaml_param_parser/src/parser.c
Outdated
| RCL_SET_ERROR_MSG("YAML file path is NULL"); | ||
| RCUTILS_SET_ERROR_MSG("YAML file path is NULL"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Use RCUTILS_CHECK_ARGUMENT_FOR_NULL
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
| RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING( | ||
| "The name length exceeds the MAX size %d at line %d", MAX_STRING_SIZE, line_num); | ||
| return RCL_RET_OK; | ||
| ret = RCUTILS_RET_ERROR; |
There was a problem hiding this comment.
RCUTILS_RET_ERROR -> RCL_RET_OK?
There was a problem hiding this comment.
Reading it again, I think it was wrong before.
There was a problem hiding this comment.
Yeah, that's what I thought.
|
Running CI (up to system_tests to make sure nothing broke downstream):
|
|
Re-running CI, looks like some code in |
|
The sole CI failure on Linux is due to a flake8 complaint on rclpy, which has since been fixed in ros2/rclpy#385. |
Closes #252. In preparation for pushing parameter parsing (from file and command line arguments) down to
rcl.