Skip to content

Backport #384 for Crystal.#385

Merged
nuclearsandwich merged 1 commit intocrystalfrom
backport-384
Feb 8, 2019
Merged

Backport #384 for Crystal.#385
nuclearsandwich merged 1 commit intocrystalfrom
backport-384

Conversation

@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich commented Feb 7, 2019

Backport of #384 to resolve error on the current Crystal devel branch.

@ross-desmond @nuclearsandwich
Change error to warning for multiple loggers. (#384)
c872c81 
* Change error to warning for multiple loggers

* Updating warning message

* Updating TODO message.

* Reformatting todo and uncrustify warn message.

* Add early return back in.

* Break string literal across multiple lines.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>

* Remove commented-out error and return block.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Feb 7, 2019
@nuclearsandwich nuclearsandwich self-assigned this Feb 7, 2019
@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Feb 8, 2019

Trying an overlay build Build Status

@chapulina
Copy link
Copy Markdown

chapulina commented Feb 8, 2019

/tmp/ws_overlay/src/ros2/rcl/rcl/src/rcl/logging_rosout.c:26:10: fatal error: rcutils/types/hash_map.h: No such file or directory

I think you'll need ros2/rcutils#131

@chapulina
Copy link
Copy Markdown

chapulina commented Feb 8, 2019

New CI with custom repos file that pulls rcutils from master: Build Status

@nuclearsandwich nuclearsandwich merged commit 8b3a4a0 into crystal Feb 8, 2019
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Feb 8, 2019
@nuclearsandwich nuclearsandwich deleted the backport-384 branch February 8, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

+1 more reviewer

@chapulina chapulina chapulina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nuclearsandwich nuclearsandwich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nuclearsandwich @chapulina @jacobperron @ross-desmond