Merged
Conversation
Contributor
|
@jacobperron wait sets still keep the fuzzy distinction between invalid argument and invalid entity, see here. |
Member
|
Is this ready for review? |
Member
Author
Sure :) |
wjwwood
approved these changes
Nov 6, 2018
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, other than one question
| client->impl, "client's rmw implementation is invalid", return false); | ||
| options = _client_get_options(client); | ||
| RCL_CHECK_FOR_NULL_WITH_MSG( | ||
| options, "client's options pointer is invalid", return false); |
Member
There was a problem hiding this comment.
What's the rationale for removing the check of the options? Does it prevent this functions reuse somewhere else or something?
Member
Author
There was a problem hiding this comment.
I thought it was redundant since options is not a pointer in the underlying impl struct, which is already checked in the line above.
The private function _client_get_options() returns the address, and the user-facing rcl_client_get_options() calls rcl_client_is_valid() anyways.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_is_valid()function (if such a function exists).RCL_RET_INVALID_ARGUMENTwithRCL_RET_*_INVALIDwhere possible.RCL_RET_BAD_ALLOCwhere appropriate.