Cleanup test_count_matched test to handle non-DDS RMWs#1164
Merged
clalancette merged 5 commits intorollingfrom Jul 1, 2024
Merged
Cleanup test_count_matched test to handle non-DDS RMWs#1164clalancette merged 5 commits intorollingfrom
clalancette merged 5 commits intorollingfrom
Conversation
This allows us to pass fewer parameters into each each invocation, and allows us to hide some more of the implementation inside the class. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
It just better reflects what these structures are. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This just ensures that they are always cleaned up, even if we exit early. Note that we specifically do *not* use it for test_count_matched_functions, since the cleanup is intentionally interleaved with other tests. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Some RMWs may have different compatibility than DDS, so check with the RMW layer to see what we should expect for the number of publishers and subscriptions. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
CI:
|
ahcorde
approved these changes
Jun 28, 2024
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
Two minor comments, LGTM with green CI
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
New CI after changes from review:
|
fujitatomoya
approved these changes
Jun 28, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Yadunund
approved these changes
Jun 28, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to update the test_count_matched test so that it handles non-DDS RMWs. Along the way, it also does some cleanup in the test. The patches are:
check_stateis a protected class method, rather than a free function. That way it can use more of the internal details of the class, which it depends on anyway.rmw_zenohwill happily match BEST_EFFORT publishers to RELIABLE subscriptions, while the DDS RMWs will not. Luckily, we have the function calledrmw_qos_profile_check_compatiblethat we can call to tell whether the underlying RMW would match them, so we can use that here.