Fix a format-security warning when building with clang.#1064
Merged
Fix a format-security warning when building with clang.#1064
Conversation
In particular, you should never have a "bare" string in a printf-like call; that could potentially access uninitialized memory. Instead, make sure to format the string with %s. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
|
CI:
|
fujitatomoya
approved these changes
Apr 19, 2023
iuhilnehc-ynos
approved these changes
Apr 20, 2023
mjcarroll
added a commit
that referenced
this pull request
Apr 20, 2023
This reverts commit 8dca59e.
Member
|
This shouldn't have been merged as we are currently frozen for Iron. |
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
In particular, you should never have a "bare" string in a printf-like call; that could potentially access uninitialized memory. Instead, make sure to format the string with %s. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
In particular, you should never have a "bare" string in a printf-like call; that could potentially access uninitialized memory. Instead, make sure to format the string with %s. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
In particular, you should never have a "bare" string in a printf-like call; that could potentially access uninitialized memory. Instead, make sure to format the string with %s. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, you should never have a "bare" string in a printf-like call; that could potentially access uninitialized memory. Instead, make sure to format the string with %s.