Revert "Implement validity checks for time points (#1018)"#1022
Merged
methylDragon merged 1 commit intoros2:rollingfrom Dec 5, 2022
Merged
Revert "Implement validity checks for time points (#1018)"#1022methylDragon merged 1 commit intoros2:rollingfrom
methylDragon merged 1 commit intoros2:rollingfrom
Conversation
This reverts commit e47ed58. Signed-off-by: methylDragon <methylDragon@gmail.com>
9f616d5 to
71b6240
Compare
Contributor
Author
|
fujitatomoya
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting out this change from #1021
This was from an internal discussion that concluded that checking for time validity on a time point doesn't make sense (std::chrono's time points have no concept of validity, a time point reflecting (0, 0) is valid.) Instead, what matters is if a clock has a time point or not.