Skip to content

Add tests checking when a graph guard condition is triggered #574

@ivanpauno

Description

@ivanpauno

Feature request

Feature description

There are currently some tests for this (here), but those are a bit fragile and aren't checking that the graph guard condition is being triggered for all the possible graph changes.

Implementation considerations

I imagine the tests looking like:

> create another node
  > assert that graph guard condition is triggered within a timeout
> create a publisher
  > assert that graph guard condition is triggered within a timeout
... etc for other possible graph changes

instead of using a thread.

Unrelated note: Some of the current graph tests are sleeping with a timeout. Waiting on a graph guard condition trigger in a loop until the desired change is detected would be more reliable.

(edit) Extended the description.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions