-
Notifications
You must be signed in to change notification settings - Fork 191
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Feature request
Feature description
As discussed in the actions design doc, we should rename the goal state transitions to use active verbs.
Basically, the following event names:
rcl/rcl_action/include/rcl_action/types.h
Lines 101 to 103 in 1d8b831
| GOAL_EVENT_SET_SUCCEEDED, | |
| GOAL_EVENT_SET_ABORTED, | |
| GOAL_EVENT_SET_CANCELED, |
can be renamed to
GOAL_EVENT_SUCCEED,
GOAL_EVENT_ABORT,
GOAL_EVENT_CANCEL,
Implementation considerations
This likely affects some downstream dependencies (e.g. rclcpp_action and rclpy), although it should not have a big impact since it's just renaming variables/functions.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request