This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Merged
Conversation
Member
Author
Oh do we have a preference for format 3 ? I usually use format 3 only when I need format 3 features, but am totally fine changing it to format 3 if it's preferred |
Member
|
Dunno, I always use format 3 in ROS 2. No reason, just using the latest and greatest. |
Member
Author
Fine by me 49e4ab0 |
This was referenced Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we have control over this repository I figured it would be better to have the package.xml leaving alongthe code rather than a patch on the release repository.
@nuclearsandwich I removed 2 dependencies that didn't appread to be necessary on my bionic machine
https://github.com/ros2-gbp/poco_vendor-release/blob/7c74e1bfa5d5596fa957817c06cca3ee3b19862c/xenial/package.xml#L14-L15
I tested it by ensuring that these 2 packages were not present and building up to the "composition" package and ran the test of "composition" successfully (couldnt test it on CI as these deps are brought in transitively by other packages like opencv or python3-dev).