Export dependency on benchmark and osrf_testing_tools_cpp#8
Merged
Conversation
This should ensure that those targets are imported and available to link against when the macros are invoked. Signed-off-by: Scott K Logan <logans@cottsay.net>
brawner
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should ensure that those targets are imported and available to link against when the macros are invoked.
We've been getting away with this when invoking
add_performance_testfrom the root scope of a project, because these packages arefind_package()'d as part of the-extras.cmakeprocessing ofperformance_test_fixtureandament_cmake_google_benchmark. However, when we invokeadd_performance_testfrom another scope, we need to ensure that they are explicitly available.I can't explain why explicitly
find_package()-ing these targets from the other scopes didn't work around the problem, but this seems to resolve the issue.