Skip to content

adding code import references in comments#6

Merged
tfoote merged 3 commits intomasterfrom
import_references
May 2, 2019
Merged

adding code import references in comments#6
tfoote merged 3 commits intomasterfrom
import_references

Conversation

@tfoote
Copy link
Copy Markdown
Contributor

@tfoote tfoote commented Aug 17, 2018

Referencing where the code was copied from for better traceability.

@tfoote tfoote self-assigned this Aug 17, 2018
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Aug 17, 2018
@tfoote
Copy link
Copy Markdown
Contributor Author

tfoote commented Aug 17, 2018

@gaoethan When I restructured your test here: https://github.com/gaoethan/message_filters-1/blob/32898573597eb115f3d4d6cb24aeace6e4ad3eca/test/test_fuzz.cpp I assumed that it had been copied from somewhere due to the 2008 Willow Garage copyright. However looking at it I cannot find where it came from as imported here: 193cf7b#diff-3969d386a591d68079e4e7903ef87e13

Did it start as another file and you modified it?

@gaoethan
Copy link
Copy Markdown
Contributor

@tfoote Actually, it's more like the tests within time_sequencer_unittest.cpp but with self-defined messages, you can see they have similiar code structure, thanks !

tfoote added 2 commits April 30, 2019 18:33
From: #6 (comment)

Signed-off-by Tully Foote <tfoote@osrfoundation.org>
@tfoote tfoote added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 1, 2019
@tfoote tfoote merged commit 8dbdd1a into master May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the import_references branch May 2, 2019 21:33
@tfoote tfoote removed the in review Waiting for review (Kanban column) label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants