[foxy] Asynchronously wait for load node service response (#174)#240
Merged
jacobperron merged 1 commit intofoxyfrom May 27, 2021
Merged
[foxy] Asynchronously wait for load node service response (#174)#240jacobperron merged 1 commit intofoxyfrom
jacobperron merged 1 commit intofoxyfrom
Conversation
* Asynchronously wait for load node service response Fixes #171 By asychronously waiting for the service response, we can monitor if launch is shutting down and abandon the request so we don't block the shutdown process. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add back debug log It was accidentally removed. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
approved these changes
May 26, 2021
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #174 to Foxy.