Skip to content

Fix exception when launch process with environment variables#96

Merged
wjwwood merged 2 commits intomasterfrom
process_with_env
Jul 9, 2018
Merged

Fix exception when launch process with environment variables#96
wjwwood merged 2 commits intomasterfrom
process_with_env

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jul 3, 2018

Launching a process with an environment variable using ros2-bouncy raises an exception.

  File "/opt/ros/bouncy/lib/python3.6/site-packages/launch/actions/execute_process.py", line 165, in __init__
    normalize_to_list_of_substitutions(value)
TypeError: unhashable type: 'list'

ExecuteProcess tries to store a list of substitutions as a dictionary key. This PR adds a test and changes __env to be a list of 2-tuple instead.

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz added bug Something isn't working in review Waiting for review (Kanban column) labels Jul 3, 2018
@sloretz sloretz self-assigned this Jul 3, 2018
@sloretz sloretz changed the title Fix exception when launch process with environment varialbes Fix exception when launch process with environment variables Jul 3, 2018
@wjwwood wjwwood merged commit 436c484 into master Jul 9, 2018
@wjwwood wjwwood deleted the process_with_env branch July 9, 2018 04:40
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jul 9, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Jul 12, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@sloretz sloretz

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @wjwwood