Conversation
| prev_handler = signal.signal(signal.SIGINT, signal.SIG_IGN) | ||
| if prev_handler is signal.SIG_IGN: | ||
| # This function has been called re-entrantly. | ||
| return |
There was a problem hiding this comment.
Is this expected to occur and be ok? If yes and then no, should it raise an exception?
Is this the case where a signal is received between 288 and 289?
There was a problem hiding this comment.
I am anticipating a race condition between 288 and 290, yeah. I haven't read anything to think that it's not possible.
I don't think that raising there is appropriate because the situation that caused #91 will then cause an exception, where I think that if we are already interrupting then there is no cause for concern. We print the message if we receive sigints later on but that's more for the information of the user from my understanding.
|
Merging this change that's been approved and will follow up with the other signal handlers |
|
This was responsible for instabilities in the nightlies last night because of a linter failure; addressed in ed75487 |
@wjwwood what do you think of this to address #91? I got the idea from this blog post.
If it's alright I'll extend it to the other handlers.