Skip to content

Add delay parameter to retry_on_failure decorator#390

Merged
jacobperron merged 3 commits intomasterfrom
jacob/retry_delay
Feb 27, 2020
Merged

Add delay parameter to retry_on_failure decorator#390
jacobperron merged 3 commits intomasterfrom
jacob/retry_delay

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Feb 25, 2020

Also added documentation for the parameters to the docstring.

Motivated by flaky tests in ros2action: ros2/ros2cli#454

@jacobperron
Add delay parameter to retry_on_failure decorator
8a3fdfa 
Also added documentation for the parameters to the docstring.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Feb 25, 2020
Closed
@jacobperron jacobperron added the enhancement New feature or request label Feb 25, 2020
@jacobperron jacobperron self-assigned this Feb 25, 2020
@jacobperron jacobperron requested a review from wjwwood February 25, 2020 23:01
@jacobperron
Default to zero delay
8ed2390 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
wjwwood reviewed Feb 25, 2020
View reviewed changes
dirk-thomas
dirk-thomas reviewed Feb 25, 2020
View reviewed changes
@jacobperron
Default to None
1c4be5f 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Feb 25, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

CI is also testing the dependent PR: ros2/ros2cli#459

Edit: Windows and macOS CLI failures are occurring nightly

@jacobperron jacobperron mentioned this pull request Feb 25, 2020
Merged
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Feb 25, 2020

I'm almost certain that the compiler warning is a false positive coming from the git log of cyclonedds:

15:25:50     Fix warning -Wimplicit-int-float-conversion
15:25:50     
15:25:50     ```
15:25:50     /opt/ros/master/src/eclipse-cyclonedds/cyclonedds/src/tools/pubsub/common.c:586:28: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
15:25:50         if(nanosec > nextafter(INT64_MAX, 0)) {
15:25:50                      ~~~~~~~~~ ^~~~~~~~~
15:25:50     /usr/include/stdint.h:134:22: note: expanded from macro 'INT64_MAX'
15:25:50                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:25:50     /usr/include/stdint.h:116:24: note: expanded from macro '__INT64_C'
15:25:50                             ^~~~~~
15:25:50     <scratch space>:345:1: note: expanded from here
15:25:50     9223372036854775807L
15:25:50     ^~~~~~~~~~~~~~~~~~~~
15:25:50     1 warning generated.
15:25:50     ```

😄

@jacobperron jacobperron merged commit ddfb59f into master Feb 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/retry_delay branch February 27, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

+1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jacobperron jacobperron

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobperron @wjwwood @dirk-thomas