Conversation
dirk-thomas
reviewed
Jul 19, 2019
| process, | ||
| cmd_args=None, | ||
| *, | ||
| timeout=10): |
Member
There was a problem hiding this comment.
I see that the code was using alignment before but our style guide explicitly avoids that. Please wrap after the open parenthesis and indent the following lines one level.
Author
|
This fixes issues in |
c4fd5ea to
45c12e9
Compare
- Generalize output checking tools. - Ease process launch and interaction. - Fix parameterization support. - Fix pytest hooks. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
45c12e9 to
9891ee0
Compare
Author
|
Same as in ros2/ros2cli#304, 9891ee0 introduces significant changes and improvements. Splitting could be an option, though it'll probably be some work. |
dirk-thomas
approved these changes
Oct 15, 2019
ivanpauno
approved these changes
Oct 16, 2019
Member
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM with green CI (make sure all existing launch based tests are run).
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
CI (full, against Fast-RTPS, Connext and Opensplice)
|
ivanpauno
approved these changes
Oct 16, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
mjcarroll
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request encompasses all additions to
launch, and mainlylaunch_testing, to allow for CLI commands testing.Connected to ros2/ros2cli#304.