Closed
Conversation
wjwwood
reviewed
Jan 29, 2019
Member
wjwwood
left a comment
There was a problem hiding this comment.
Other than my suggested alternative, I think this looks good.
wjwwood
approved these changes
Jan 30, 2019
Contributor
Author
|
I'll close this PR for now and reopen when an implementation is ready |
This was referenced Mar 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #160, opening for discussion
This adds examples for launching composable nodes. One is the same as slide 8 of https://roscon.ros.org/2018/presentations/ROSCon2018_launch.pdf with
ExecuteComposableNodeProcessrenamed toComposableNodeContainerandComposableNodeDescriptionrenamed toComposableNode. The other example assumes anOnProcessStartevent handler is created.