add GroupAction for conditionally including other actions and scoping#133
Merged
add GroupAction for conditionally including other actions and scoping#133
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
Author
|
CI:
|
dirk-thomas
approved these changes
Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #106
See #106 for details of how it works, but in short it's an action that just yields other actions (sort of like a launch description, but without a source) and it can also have a condition for its inclusion (like all actions) and it can also optionally scope all changes to launch configurations made by actions within it.
This class is mostly syntactic sugar since it only uses other existing actions to be implemented.