Porting tf2_sensor_msgs in C++ (#2)#75
Porting tf2_sensor_msgs in C++ (#2)#75clalancette merged 2 commits intoros2:ros2from SteveMacenski:ros2
Conversation
|
Cool, here is another CI run:
|
|
Mmh. I don't actually see where tf2_sensor_msgs is being built in that output. The issues appear to me to be upstream of this. Thoughts? |
It's here: https://ci.ros2.org/job/ci_linux/5353/consoleFull#console-section-378 . The reason you don't see "much" being done is because this looks like a header-only library in C++, so all it is doing is installing the header file and surrounding infrastructure. The problems that are causing this to be yellow are indeed elsewhere in the codebase, so we can ignore those. Assuming the other builds finish with the same set of errors, I'll be happy to approve. |
clalancette
left a comment
There was a problem hiding this comment.
Yellow CI is because of other problems in the codebase unrelated to this PR.
|
Awesome, merge as you see fit |
|
Done, thanks for the contribution. |
| <run_depend>tf2</run_depend> | ||
| <run_depend>python_orocos_kdl</run_depend> | ||
| <depend>cmake_modules</depend> | ||
| <depend>Eigen3</depend> |
There was a problem hiding this comment.
I'm not sure capital Eigen3 is defined in rosdistro.
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tf2_sensor_msgs: Cannot locate rosdep definition for [Eigen3]
@clalancette , was this migration intentional?
There was a problem hiding this comment.
@ruffsl I think you're right, I looked at rosdistro and it looks like eigen leads to eigen3 debians
There was a problem hiding this comment.
I actually don't remember at all, sorry. However, this package is released into Bouncy, so I'm pretty sure what is currently in there works one way or another.
@clalancette Lets try this again 💯