Skip to content

Removed warning (backport #682)#683

Merged
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-682
May 28, 2024
Merged

Removed warning (backport #682)#683
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-682

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented May 17, 2024

There is a new warning when compiling with clang https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1890/clang-tidy/new/folder.1973258341/

This should fix it.


This is an automatic backport of pull request #682 done by Mergify.

@mergify mergify bot added the conflicts label May 17, 2024
@mergify mergify bot requested review from ahcorde and clalancette as code owners May 17, 2024 21:01
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented May 17, 2024

Cherry-pick of dd30056 has failed:

On branch mergify/bp/jazzy/pr-682
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit dd30056f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tf2/test/cache_benchmark.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request May 17, 2024
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 17, 2024

We'll hold this for Jazzy patch release 1.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the mergify/bp/jazzy/pr-682 branch from 873e64d to 7e4a4cf Compare May 28, 2024 10:48
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 15c00f1 into jazzy May 28, 2024
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/jazzy/pr-682 branch May 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant