Merged
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
ahcorde
requested changes
Mar 1, 2024
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
There are 3 new warnings, do you mind to fix them?
https://build.ros2.org/job/Rpr__geometry2__ubuntu_jammy_amd64/263/clang-tidy/new/
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Contributor
Author
|
Yup, they're all fixed now, it seems CI errors are now related to flake8 tests in other parts of the repository. |
ahcorde
requested changes
Mar 1, 2024
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
warning are still there https://build.ros2.org/job/Rpr__geometry2__ubuntu_jammy_amd64/264/clang-tidy/new/
TF2Error is a enum of std::uint8_t
enum class TF2Error : std::uint8_tTake a look to my suggestion
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Contributor
|
ahcorde
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request directly addresses issue #570 which is meant to remove the
console_bridgedependencies from tf2 and opt for a ROS 2 solution of logging. I went with the basic forms ofRCUTILS_LOG_WARN/ERRORas it seems to be most sensible. Though, this could be swapped toRCLCPP_LOG_*or more advanced forms likeRCUTILS_LOG_WARN_NAMEDdepending on the extent of the information we want the user to have.