Suppress spam from calling canTransform (backport #529)#615
Merged
clalancette merged 1 commit intohumblefrom Aug 3, 2023
Merged
Suppress spam from calling canTransform (backport #529)#615clalancette merged 1 commit intohumblefrom
clalancette merged 1 commit intohumblefrom
Conversation
* suppress spam in canTransform * Uncrustify Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Suppress console spam in other calls to canTransform The user has few options to workaround potential console spam from canTransform. If we want, it would be better to update the API to optional return the error string. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Grigoriy Lipenko <gnlipenko@sberautotech.ru> Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 8c2aa5a)
Contributor
|
CI:
|
Contributor
|
After thinking about this more, I'm not entirely convinced we want to do this in Humble. While it does suppress the spam, it also substantially changes the messages being output by Humble. While that isn't expressly disallowed by our API/ABI policy, I do think it will be a surprise for users. So possibly we shouldn't do this in Humble, I'm not sure. @ahcorde thoughts here? |
Contributor
|
After discussing this at the Waffle meeting, we decided that this change in behavior was OK. I'll go ahead and merge this, but @ahcorde if you have another opinion please feel free to leave it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #529 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com