Skip to content

Small geometry2 cleanups#466

Merged
clalancette merged 7 commits intoros2from
clalancette/tf2-cmake-cleanups
Oct 14, 2021
Merged

Small geometry2 cleanups#466
clalancette merged 7 commits intoros2from
clalancette/tf2-cmake-cleanups

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

@clalancette clalancette commented Oct 13, 2021

This PR does a number of small things in geometry2:

  1. Removes an unused speed_test
  2. Cleanups up the tf2/CMakeLists.txt to remove unused portions
  3. Adds rosidl_runtime_cpp as an explicit dependency to tf2
  4. Removes some references to the ROS 1 wiki

It's all fairly minor things that I noticed while doing some deeper fixes in tf2 (which will come as a separate PR later).

@clalancette
Remove unused speed_test from tf2.
0b68d1b 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Remove completely unnecessary target_link_libraries.
80a7a04 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Remove include directory that doesn't exist.
bf4ce52 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Minor cleanups in CMakeLists.txt.
cd03c4b 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Add rosidl_runtime_cpp as build_depend and build_export_depend.
3d680d8 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Remove some references to the ROS 1 wiki.
18f49bb 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
aprotyas
aprotyas reviewed Oct 13, 2021
View reviewed changes
@clalancette
Remove unnecessary test dependencies.
b5d9de8 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Oct 13, 2021

CI (--packages-above-and-dependencies tf2; the changes to the other packages are all in documentation):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 83fbeb7 into ros2 Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/tf2-cmake-cleanups branch October 14, 2021 12:26
@aprotyas aprotyas mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aprotyas aprotyas aprotyas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clalancette @aprotyas