Use ament_target_dependencies to ensure correct dependency order#156
Merged
jacobperron merged 2 commits intoros2from Aug 27, 2019
Merged
Use ament_target_dependencies to ensure correct dependency order#156jacobperron merged 2 commits intoros2from
jacobperron merged 2 commits intoros2from
Conversation
Resolves compilation issues when building in an overlayed workspace. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Aug 26, 2019
dirk-thomas
approved these changes
Aug 26, 2019
Member
Author
|
Contributor
|
Thanks for fixing this. I still am baffled on what the issue was and why this resolved it, but appreciate it got fixed right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves compilation issues when building in an overlayed workspace.
Resolves issue mentioned in #121 (comment)