Skip to content

Use char * in logging macros#295

Merged
audrow merged 2 commits intomasterfrom
audrow/update-logging
Dec 18, 2020
Merged

Use char * in logging macros#295
audrow merged 2 commits intomasterfrom
audrow/update-logging

Conversation

@audrow
Copy link
Copy Markdown
Member

@audrow audrow commented Dec 10, 2020

This PR is part of ros2/rclcpp#1442.

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow audrow self-assigned this Dec 10, 2020
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@audrow
Copy link
Copy Markdown
Member Author

audrow commented Dec 18, 2020

Here's CI for ros2/rclcpp#1442, which includes this change:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit 869e303 into master Dec 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the audrow/update-logging branch December 18, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants