Backport Python Action examples to Crystal#229
Merged
nuclearsandwich merged 1 commit intocrystalfrom Mar 10, 2019
Merged
Conversation
* Copy rclpy action examples from #216 * Bump version of examples_rclpy_action to match other packages * Consolidate composable action client example * Add action client example that is not composable * Wait for action server * Restructure into separate packages for action client and action server examples This package structure is consistent with examples for services and topics. * Update API in action server examples * Rename action server examples Now the 'simplest' example is 'server.py'. * Add action server example that is not composable * Update setup.py * Fix syntax * Update action client examples to use goal handle API for the result Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Improve action client output and result handling Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update action server examples Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Move action examples into Python packages This avoid top-level module names from clashing when installed. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add action client cancel example Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address review comments * Update author * Update copyright year * Shutdown client example after result received Signed-off-by: Jacob Perron <jacob@openrobotics.org> * GoalResponse.ACCEPT_AND_EXECUTE -> GoalResponse.ACCEPT Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix client_cancel example Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove race from server_single_goal example Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add action server example that defers the execution of an accepted goal Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Reduce the timer period for the client cancel example This makes it easy to experiment with the scenario where a deferred goal is canceled prior to execution. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Support canceling goals with non-composable action server example Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add action server example that queues goals Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address review - Fix comment - Add author tag to package.xml Signed-off-by: Jacob Perron <jacob@openrobotics.org>
10 tasks
nuclearsandwich
approved these changes
Mar 10, 2019
Member
|
CI building actions examples
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only one new commit since the last release (#222).