Skip to content

Initialized count in examples_rclcpp_multithreaded_executor#269

Merged
ahcorde merged 1 commit intomasterfrom
ahcorde/fix/multithreaded_executor_count
May 12, 2020
Merged

Initialized count in examples_rclcpp_multithreaded_executor#269
ahcorde merged 1 commit intomasterfrom
ahcorde/fix/multithreaded_executor_count

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented May 12, 2020

Initialized count variable in examples_rclcpp_multithreaded_executor. In Linux seems to work properly but on Windows the generate a random number each time that the executable is launched.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the bug Something isn't working label May 12, 2020
@ahcorde ahcorde requested a review from jacobperron May 12, 2020 12:52
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks good to me with green CI.

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented May 12, 2020

Compiling up-to examples_rclcpp_multithreaded_executor. There is no test for this package:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f7acea1 into master May 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/fix/multithreaded_executor_count branch May 12, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants