Skip to content

Comment mapping_rules.yaml#156

Merged
dhood merged 1 commit intomasterfrom
comment-mapping
Dec 15, 2016
Merged

Comment mapping_rules.yaml#156
dhood merged 1 commit intomasterfrom
comment-mapping

Conversation

@dhood
Copy link
Copy Markdown
Member

@dhood dhood commented Dec 15, 2016

its purpose is not clear when looking at the example_interfaces package alone

@dhood dhood self-assigned this Dec 15, 2016
@dhood dhood added the in progress Actively being worked on (Kanban column) label Dec 15, 2016
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Dec 15, 2016

The purpose is clear when looking at the package manifest. The file is being referenced using the tag ros1_bridge and the attribute mapping_rule.

The comment in the yaml is benefitiial nevertheless. 👍

@dhood
Copy link
Copy Markdown
Member Author

dhood commented Dec 15, 2016

yep, good point. merging thanks.

@dhood dhood merged commit 307425f into master Dec 15, 2016
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Dec 15, 2016
@dhood dhood deleted the comment-mapping branch December 15, 2016 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants