map sequence to Python array.array()#217
Merged
dirk-thomas merged 1 commit intogh-pagesfrom Mar 21, 2019
Merged
Conversation
hidmic
approved these changes
Mar 21, 2019
hidmic
left a comment
There was a problem hiding this comment.
LGTM, but what about char and wchar types? As it stands, it looks like we'll end up with a list of them.
Member
Author
What are you suggesting for those types? As far as I can see there are no corresponding
Correct. |
|
Hmm, I initially noticed 'b', 'B' and 'u', but on a second look, it treats the first two as numbers and using 'u' would result on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch proposes to map (un)bounded sequences of numerics to array.array instead of numpy.ndarray.
An array provides the same interface as a Python list. It only uses memory closer to what the C representation needs (similar even though slightly higher than
numpy) and also checks the value range of each item based on the typecode.