Skip to content

Use default on_activate()/on_deactivate implemenetation of Node#552

Merged
ivanpauno merged 1 commit intomasterfrom
ivanpauno/lifecycle-automatically-transition-entities
Jan 24, 2022
Merged

Use default on_activate()/on_deactivate implemenetation of Node#552
ivanpauno merged 1 commit intomasterfrom
ivanpauno/lifecycle-automatically-transition-entities

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Copy Markdown
Member Author

CI passed here.
I will do a new rclcpp release before merging this.

@ivanpauno
Copy link
Copy Markdown
Member Author

@ros-pull-request-builder retest this please

1 similar comment
@ivanpauno
Copy link
Copy Markdown
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Copy Markdown
Member Author

I couldn't reproduce the issue locally, once again:

@ros-pull-request-builder retest this please.

@clalancette
Copy link
Copy Markdown
Contributor

@ros-pull-request-builder retest this please.

@ivanpauno ivanpauno merged commit bee316c into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/lifecycle-automatically-transition-entities branch January 24, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants