Skip to content

Replace rmw_connext_cpp with rmw_connextdds#489

Merged
clalancette merged 3 commits intoros2:masterfrom
asorbini:asorbini/rmw_connextdds
Mar 24, 2021
Merged

Replace rmw_connext_cpp with rmw_connextdds#489
clalancette merged 3 commits intoros2:masterfrom
asorbini:asorbini/rmw_connextdds

Conversation

@asorbini
Copy link
Copy Markdown
Contributor

@asorbini asorbini commented Mar 5, 2021 •
edited
Loading

This PR replaces all references to rmw_connext_cpp with rmw_connextdds.

See rticommunity/rmw_connextdds #9 for a list of related PRs, and an overview of all the changes required to replace ros2/rmw_connext (rmw_connext_cpp) with rticommunity/rmw_connextdds in the ROS2 source tree.

@asorbini asorbini mentioned this pull request Mar 5, 2021
Closed
fujitatomoya
fujitatomoya reviewed Mar 8, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are still needed?

demos/pendulum_control/test/test_pendulum_demo.py.in

Lines 59 to 64 in ed0299d

if rmw_implementation.startswith('rmw_connext'):
# This output can be caused by a small QoS depth leading to samples being discarded.
# Since we are optimizing for performance with a depth of 1, we can ignore it.
filtered_prefixes.append(
'PRESWriterHistoryDriver_completeBeAsynchPub:!make_sample_reclaimable'
)

demos/pendulum_control/test/test_pendulum_teleop.py.in

Lines 63 to 68 in ed0299d

if rmw_implementation.startswith('rmw_connext'):
# This output can be caused by a small QoS depth leading to samples being discarded.
# Since we are optimizing for performance with a depth of 1, we can ignore it.
filtered_prefixes.append(
'PRESWriterHistoryDriver_completeBeAsynchPub:!make_sample_reclaimable'
)

ivanpauno
ivanpauno approved these changes Mar 8, 2021
View reviewed changes
@asorbini
Copy link
Copy Markdown
Contributor Author

asorbini commented Mar 8, 2021 •
edited
Loading

these are still needed?

@fujitatomoya I'm not sure, since I haven't tried removing them (and re-running the tests without them). I left them in to be on the safe side (since the tests are passing "as is"), but I can try removing them and seeing what happens.

@ivanpauno if you want I can push a commit to also remove references to opensplice, but maybe those would be better tracked via a different PR? If so, I can do that too while I'm at it.

EDIT: I realize now that creating a separate PR will only complicate things, so I'll just push a commit to this branch.

asorbini and others added 3 commits March 24, 2021 13:11
@asorbini @clalancette
Replace rmw_connext_cpp with rmw_connextdds
6370828 
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
@asorbini @clalancette
Remove references to OpenSplice
53a4984 
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
@clalancette
More cleanups of the pendulum_control README.
e6e3ef2 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the asorbini/rmw_connextdds branch from bd1935c to e6e3ef2 Compare March 24, 2021 13:11
@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Mar 24, 2021

PR build failed, but it seems to be doing that for all PRs. Given that this is just a change to the README files, I'm going to go ahead and merge.

@clalancette clalancette merged commit 10764cf into ros2:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette clalancette approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asorbini @clalancette @ivanpauno @fujitatomoya