Demo to show the working of the incompatible_qos event callbacks.#416
Merged
ivanpauno merged 12 commits intoros2:masterfrom Apr 1, 2020
Merged
Demo to show the working of the incompatible_qos event callbacks.#416ivanpauno merged 12 commits intoros2:masterfrom
ivanpauno merged 12 commits intoros2:masterfrom
Conversation
14 tasks
dae0e45 to
586626a
Compare
piraka9011
reviewed
Nov 22, 2019
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Show resolved
Hide resolved
piraka9011
reviewed
Nov 22, 2019
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Show resolved
Hide resolved
piraka9011
approved these changes
Nov 22, 2019
115b22c to
0bff4ec
Compare
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
0bff4ec to
a178cd5
Compare
…istent Signed-off-by: Miaofei <miaofei@amazon.com>
d394d14 to
21be241
Compare
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
ivanpauno
approved these changes
Mar 31, 2020
quality_of_service_demo/rclpy/quality_of_service_demo_py/incompatible_qos.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Miaofei <miaofei@amazon.com>
Member
|
@ros2/aws-oncall - please run this CI job |
ivanpauno
approved these changes
Apr 1, 2020
|
Member
|
@ivanpauno, there is a random buildfarm failure for the Linux-aarch64 run. Can we merge this pull request? |
Member
Yes, I think it's safe to merge (considering that the last commit are just style changes and this PR has already passed CI before). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this feature request. The design and implementation details can also be found there.
Signed-off-by: Jaison Titus jaisontj92@gmail.com