Update for OpenCV v4.0 compatibility#306
Merged
jacobperron merged 2 commits intomasterfrom Jan 11, 2019
Merged
Conversation
nuclearsandwich
approved these changes
Jan 10, 2019
Member
nuclearsandwich
left a comment
There was a problem hiding this comment.
LGTM as long as it passes CI on Xenial, our current Windows builds, and MacOS with the latest OpenCV formula.
wjwwood
approved these changes
Jan 10, 2019
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, with one comment.
Thanks for looking into it.
image_tools/src/burger.cpp
Outdated
| burger_buf = cv::Mat(height_i, width_i, CV_8UC3); | ||
| } | ||
| burger_buf = cvScalar(0, 0, 0); | ||
| burger_buf = cv::Scalar_<int>(0, 0, 0); |
Member
There was a problem hiding this comment.
Is there any reason you're using int specifically rather than double, i.e. cv::Scalar? I assume there is, but I'm just curious.
Member
Author
There was a problem hiding this comment.
Oops, no. I think this should just be cv::Scalar 😬
Fixed in 2877adb
Member
Author
|
Packages up to image_tools:
|
mjcarroll
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.