Added serialized listener demo for python#287
Merged
Karsten1987 merged 4 commits intoros2:masterfrom Jan 10, 2019
Merged
Conversation
Karsten1987
approved these changes
Nov 25, 2018
Contributor
Karsten1987
left a comment
There was a problem hiding this comment.
lgtm. A few minor nitpicks
Contributor
|
@josephduchesne I hope you don't mind. I edited your comment to connect this PR to your |
…duchesne/demos into demo-nodes-py-serialized-listener
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclpy#242
This was added at the suggestion of @Karsten1987 for ros2/rclpy/pull/242
This is a python analog of listener_serialized_message.cpp in demo_nodes_cpp.
For it to work, you need to be on the rclpy branch in my pull request, or that PR has to be merged in.
As a result, this should not be merged until ros2/rclpy/pull/242 is.