Skip to content

Use escalated namespaces for more entities#199

Merged
dhood merged 1 commit intomasterfrom
escalated_namespaces
Nov 30, 2017
Merged

Use escalated namespaces for more entities#199
dhood merged 1 commit intomasterfrom
escalated_namespaces

Conversation

@dhood
Copy link
Copy Markdown
Member

@dhood dhood commented Nov 30, 2017

connects to ros2/rclcpp#410 (escalating more namespaces)
requires ros2/rclcpp#410

Demos were using rclcpp::Publisher but rclcpp::service::Service (because it hadn't been escalated)

@dhood dhood self-assigned this Nov 30, 2017
@dhood dhood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 30, 2017
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@dhood dhood merged commit af6fa66 into master Nov 30, 2017
@dhood dhood deleted the escalated_namespaces branch November 30, 2017 21:27
@dhood dhood removed the in review Waiting for review (Kanban column) label Nov 30, 2017
@dhood
Copy link
Copy Markdown
Member Author

dhood commented Nov 30, 2017

CI is in ros2/rclcpp#410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants