Skip to content

Uniform CMAKE min VERSION#714

Merged
ahcorde merged 2 commits intoros2:rollingfrom
mosfet80:updateCMAKE_MINVersion
Apr 8, 2025
Merged

Uniform CMAKE min VERSION#714
ahcorde merged 2 commits intoros2:rollingfrom
mosfet80:updateCMAKE_MINVersion

Conversation

@mosfet80
Copy link
Copy Markdown
Contributor

@mosfet80 mosfet80 commented Apr 3, 2025 •
edited
Loading

demo_nodes_cpp/CMakeLists.txt require cmake min version 3.12 other modules cmake 3.5. It is proposed to standardize with version 3.20 (rolling requirement).
This also fixes cmake <3.10 deprecation warnings

ahcorde
ahcorde requested changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to sign the commit https://github.com/ros2/demos/pull/714/checks?check_run_id=39901809903 ?

fujitatomoya
fujitatomoya approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with DCO fix.

https://cmake.org/cmake/help/latest/release/3.31.html

for most modern C++ projects, a good starting point is CMake 3.10 or later now.

https://github.com/ros-infrastructure/rep/blob/master/rep-2000.rst

  • Humble CMake oldest version: 3.14 (Including Tier III)
  • Jazzy CMake oldest version: 3.20 (Including Tier III)

i think it is okay to upgrade version 3.20 for rolling and jazzy, 3.14 for humble as base version.

@mosfet80 mosfet80 force-pushed the updateCMAKE_MINVersion branch from 264b7f2 to 9a67206 Compare April 3, 2025 18:34
@mosfet80 mosfet80 requested a review from ahcorde April 3, 2025 18:48
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Apr 3, 2025

@mosfet80 DCO is still missing.

@mosfet80 mosfet80 changed the title Uniform CMAKE min VERION Uniform CMAKE min VERSION Apr 5, 2025
mosfet80 added 2 commits April 5, 2025 13:02
@mosfet80
Uniform CMAKE min VERION
cec2d62 
demo_nodes_cpp/CMakeLists.txt require cmake min version 3.12 other modules cmake 3.5.
It is proposed to standardize with version 3.12.
This also fixes cmake <3.10 deprecation warnings

Signed-off-by: Andrea <realeandrea@yahoo.it>
@mosfet80
switch to 3.20
1fa0511 
Signed-off-by: Andrea <realeandrea@yahoo.it>
@mosfet80 mosfet80 force-pushed the updateCMAKE_MINVersion branch from 2302b36 to 1fa0511 Compare April 5, 2025 11:04
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 7, 2025

Pulls: #714
Gist: https://gist.githubusercontent.com/ahcorde/2f48fb2ef5f725b783f916e801dfb46c/raw/ae305d28055aa14007c9b2ed8ff7f3b1d051c03d/ros2.repos
BUILD args: --packages-up-to action_tutorials_cpp composition demo_nodes_cpp demo_nodes_cpp_native dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp topic_statistics_demo --packages-above-and-dependencies action_tutorials_cpp composition demo_nodes_cpp demo_nodes_cpp_native dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp topic_statistics_demo
TEST args: --packages-select action_tutorials_cpp composition demo_nodes_cpp demo_nodes_cpp_native dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp topic_statistics_demo --packages-above action_tutorials_cpp composition demo_nodes_cpp demo_nodes_cpp_native dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp topic_statistics_demo
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15610

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9b1db07 into ros2:rolling Apr 8, 2025
3 checks passed
@fujitatomoya fujitatomoya mentioned this pull request Apr 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosfet80 @fujitatomoya @ahcorde