Fix two small bugs in the fibonacci C++ tutorial.#564
Merged
clalancette merged 1 commit intomasterfrom May 18, 2022
Merged
Conversation
The first bug has to do with the action client, and what happens if the server rejects the goal. In the current code, the client would just hang around forever. If the server rejects the goal, make sure the client shuts down. The second bug has to do with the size that the action server can support. The code has more information, but essentially because of the Fibonacci action message, we can only support sequences up to order 46; anything larger than that will cause integer wrapping. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first bug has to do with the action client, and what happens
if the server rejects the goal. In the current code, the
client would just hang around forever. If the server rejects
the goal, make sure the client shuts down.
The second bug has to do with the size that the action server
can support. The code has more information, but essentially
because of the Fibonacci action message, we can only support
sequences up to order 46; anything larger than that will cause
integer wrapping.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org