Skip to content

[action_tutorials_cpp] Return without sending goal if exiting#415

Merged
sloretz merged 1 commit intomasterfrom
sloretz/return_before_sending_goal
Nov 13, 2019
Merged

[action_tutorials_cpp] Return without sending goal if exiting#415
sloretz merged 1 commit intomasterfrom
sloretz/return_before_sending_goal

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Nov 13, 2019

If the action client does not see an action server within 10 seconds, it shuts down. However, it currently tries to send the goal after shutting down.

$ ros2 run action_tutorials_cpp fibonacci_action_client 
[ERROR] [fibonacci_action_client]: Action server not available after waiting
[INFO] [fibonacci_action_client]: Sending goal

This PR changes behavior to exit without trying to send the goal.

@sloretz
Return without sending goal if exiting
72d8d28 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Nov 13, 2019
@sloretz sloretz self-assigned this Nov 13, 2019
hidmic
hidmic approved these changes Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Nov 13, 2019

CI (testing just action_tutorials_cpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit b10f45c into master Nov 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the sloretz/return_before_sending_goal branch November 13, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@sloretz sloretz

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @hidmic